Skip to content

feat(aten::view): Adds support for ATen view also fixes some tests #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

feat(aten::view): Adds support for ATen view also fixes some tests #63

merged 1 commit into from
May 20, 2020

Conversation

narendasan
Copy link
Collaborator

Description

Adds support for aten::view

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan
feat(aten::view): Adds support for ATen view also fixes some tests
24b422e 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@narendasan narendasan added the component: converters Issues re: Specific op converters label May 20, 2020
@narendasan narendasan merged commit d46676d into master May 20, 2020
@narendasan narendasan deleted the aten_view branch May 20, 2020 22:47
frank-wei pushed a commit that referenced this pull request Jun 4, 2022
[fx2trt] pass rewrite for setitem (#63)
aecbd21 
Summary:
Pull Request resolved: https://github.com/pytorch/fx2trt/pull/63

Pass rewrite for setitem to bypass the limitation in TRT.
This rewrite will happen after torchdynamo tracing and before acc tracing.

Reviewed By: yinghai

Differential Revision: D35981364

fbshipit-source-id: 22e26c3c5123b395c3c5f815a0f00914623e20b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: converters Issues re: Specific op converters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@narendasan