Disable fail-fast in CI #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of our CI failures are because there's some missing missing flag/feature available in nightlies or because some cpu of cuda skip test wheras the behavior right now is if 1 CI job fails all the other jobs get canceled. The main benefit of the old behavior is shorter queue times so we can revisit flipping this back off when/if queue times become a problem
facebook-github-bot
added
the
CLA Signed
|
cpu jobs seem stuck hmm :/ |
|
grrr |
cpuhrsch
approved these changes
Apr 23, 2024
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
* tab->spc * quantize * remove extraneous conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of our CI failures are because there's some missing missing flag/feature available in nightlies or because some cpu of cuda skip test wheras the behavior right now is if 1 CI job fails all the other jobs get canceled. The main benefit of the old behavior is shorter queue times so we can revisit flipping this back off when/if queue times become a problem
I also add a check to disable concurrent jobs what that means is let's say you send many commits to a single PR, CI will only be evaluated on the newest commit