-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add A10G support in CI #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
commented
Apr 25, 2024
@@ -449,6 +449,7 @@ def test_dynamic_quant_per_tensor_numerics_cpu(self): | |||
for row in test_cases: | |||
self._test_dynamic_quant_per_tensor_numerics_impl(*row) | |||
|
|||
@unittest.skip("test case incorrect on A10G") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HDCharles FYI
cpuhrsch
approved these changes
Apr 25, 2024
cpuhrsch
approved these changes
Apr 25, 2024
cpuhrsch
reviewed
Apr 25, 2024
@@ -1381,6 +1392,8 @@ def test_autoquant_one_input(self, device, dtype, m, k, n): | |||
(32, 32, 128, 128), | |||
])) | |||
@unittest.skipIf(not TORCH_VERSION_AFTER_2_3, "autoquant requires 2.3+.") | |||
@unittest.skipIf(TORCH_VERSION_AFTER_2_4 and torch.cuda.is_available(), "SystemError: AST constructor recursion depth mismatch (before=45, after=84)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fail for all dtypes etc.?
22 tasks
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* Add A10G support in CI * push * push * push * push * push * push * push * push * push * push * Convert to utilize linux_job.yml * switch to use linux.4xlarge * no more need for GPU checks * push * this feels gross * push * push * push --------- Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support A10G + manylinux so cuda extensions work on as many systems as possible