remove outdated Float8Linear workarounds #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
Merged
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2595
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Jul 24, 2025
Summary: These workarounds are no longer needed after #2356 and the corresponding improvements in PyTorch core. Test Plan: torchtitan bench on llama 3 8b on 8 H100s: before rowwise Median Tokens/Second (excluding step 1): 7013.0 Max Memory Usage: 37.19 GiB gw_hp Median Tokens/Second (excluding step 1): 7232.0 Max Memory Usage: 37.13 GiB after rowwise Median Tokens/Second (excluding step 1): 6984.5 Max Memory Usage: 37.19 GiB gw_hp Median Tokens/Second (excluding step 1): 7319.5 Max Memory Usage: 37.13 GiB Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ae11ea7 ghstack-comment-id: 3113561383 Pull Request resolved: #2595
vkuzo
added
the
topic: not user facing
danielvegamyhre
approved these changes
Jul 24, 2025
vkuzo
added a commit
that referenced
this pull request
Jul 24, 2025
Summary: These workarounds are no longer needed after #2356 and the corresponding improvements in PyTorch core. Test Plan: torchtitan bench on llama 3 8b on 8 H100s: before rowwise Median Tokens/Second (excluding step 1): 7013.0 Max Memory Usage: 37.19 GiB gw_hp Median Tokens/Second (excluding step 1): 7232.0 Max Memory Usage: 37.13 GiB after rowwise Median Tokens/Second (excluding step 1): 6984.5 Max Memory Usage: 37.19 GiB gw_hp Median Tokens/Second (excluding step 1): 7319.5 Max Memory Usage: 37.13 GiB Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ae11ea7 ghstack-comment-id: 3113561383 Pull Request resolved: #2595
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Update [ghstack-poisoned] * Update [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These workarounds are no longer needed after
#2356 and the corresponding
improvements in PyTorch core.
Test Plan:
torchtitan bench on llama 3 8b on 8 H100s:
before
rowwise
Median Tokens/Second (excluding step 1): 7013.0
Max Memory Usage: 37.19 GiB
gw_hp
Median Tokens/Second (excluding step 1): 7232.0
Max Memory Usage: 37.13 GiB
after
rowwise
Median Tokens/Second (excluding step 1): 6984.5
Max Memory Usage: 37.19 GiB
gw_hp
Median Tokens/Second (excluding step 1): 7319.5
Max Memory Usage: 37.13 GiB
Reviewers:
Subscribers:
Tasks:
Tags: