Skip to content

Retry of D58015187 Move AsyncCompile to a different file #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jamesjwu
Copy link
Contributor

@jamesjwu jamesjwu commented Jun 2, 2024

Summary:
X-link: pytorch/pytorch#127691

This is a retry of https://github.com/pytorch/pytorch/pull/127545/files
and
D58015187, fixing the internal test that also imported codecache

Reviewed By: oulgen

Differential Revision: D58054611

Summary:
X-link: pytorch/pytorch#127691

This is a retry of https://github.com/pytorch/pytorch/pull/127545/files
and
D58015187, fixing the internal test that also imported codecache

Reviewed By: oulgen

Differential Revision: D58054611
Copy link

pytorch-bot bot commented Jun 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/302

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 027fcce with merge base e5d27a3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58054611

jamesjwu added a commit to jamesjwu/tnt that referenced this pull request Jun 2, 2024
Summary:
X-link: pytorch/ao#302

X-link: pytorch/pytorch#127691

This is a retry of https://github.com/pytorch/pytorch/pull/127545/files
and
D58015187, fixing the internal test that also imported codecache

Reviewed By: oulgen

Differential Revision: D58054611
jamesjwu added a commit to jamesjwu/param that referenced this pull request Jun 2, 2024
Summary:
X-link: pytorch/tnt#842

X-link: pytorch/ao#302

X-link: pytorch/pytorch#127691

This is a retry of https://github.com/pytorch/pytorch/pull/127545/files
and
D58015187, fixing the internal test that also imported codecache

Reviewed By: oulgen

Differential Revision: D58054611
facebook-github-bot pushed a commit to facebookresearch/param that referenced this pull request Jun 3, 2024
Summary:
Pull Request resolved: #123

X-link: pytorch/tnt#842

X-link: pytorch/ao#302

X-link: pytorch/pytorch#127691

This is a retry of https://github.com/pytorch/pytorch/pull/127545/files
and
D58015187, fixing the internal test that also imported codecache

Reviewed By: oulgen, msaroufim

Differential Revision: D58054611

fbshipit-source-id: 7a4d6602effa51c839ee8f650548e254c82a42a4
facebook-github-bot pushed a commit to pytorch/tnt that referenced this pull request Jun 3, 2024
Summary:
X-link: facebookresearch/param#123

Pull Request resolved: #842

X-link: pytorch/ao#302

X-link: pytorch/pytorch#127691

This is a retry of https://github.com/pytorch/pytorch/pull/127545/files
and
D58015187, fixing the internal test that also imported codecache

Reviewed By: oulgen, msaroufim

Differential Revision: D58054611

fbshipit-source-id: 7a4d6602effa51c839ee8f650548e254c82a42a4
@facebook-github-bot facebook-github-bot merged commit 88daa1a into main Jun 3, 2024
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Differential Revision: D58054611

Pull Request resolved: pytorch#302
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
… default) (pytorch#302)

* chat in browser

* pass port in as an arg

* more comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants