-
Notifications
You must be signed in to change notification settings - Fork 345
make mxtensor printing nicer #3068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3068
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Sep 25, 2025
Summary: Fix printing of linear weight wrapped with MXTensor. Test Plan: quantize a Qwen MoE model with mxfp4 and print it old version would print the data for each weight new version prints this: ```python (self_attn): Qwen2MoeSdpaAttention( (q_proj): Linear(in_features=2048, out_features=2048, weight=MXTensor(self._elem_dtype=torch.float4_e2m1fn_x2, self._block_size=32, torch.bfloat16, MXGemmKernelChoice.EMULATED, self.act_quant_kwargs=QuantizeTensorToMXKwargs(elem_dtype=torch.float4_e2m1fn_x2, block_size=32, scaling_mode=<ScaleCalculationMode.FLOOR: 'floor'>, gemm_kernel_choice=<MXGemmKernelChoice.EMULATED: 'emulated'>, pack_fp6=False))) ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fc9e992 ghstack-comment-id: 3336009172 Pull Request resolved: #3068
This was referenced Sep 26, 2025
This was referenced Sep 26, 2025
danielvegamyhre
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: improvement
Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix printing of linear weight wrapped with MXTensor.
Test Plan:
quantize a Qwen MoE model with mxfp4 and print it
old version would print the data for each weight
new version prints this:
Reviewers:
Subscribers:
Tasks:
Tags: