Skip to content

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Sep 27, 2025

Higher num warps to hide nvlink latency and increase occupancy. Runtime improves by ~13x in benchmark from ~2000ms to ~150ms. (num_warps was originally 16 but changed it to 1 for debugging something, and am now changing it back - just providing context).

Still, perf is much slower than a standalone all_to_all_single_autograd - 10ms vs 150ms for shape (16,8192,5120) with 8 splits. However, the benefit is we avoid the d2h sync required to compute input/output splits for all_to_all_single and get them on the CPU/host as the impl requires.

TODO: bench against bf16 a2a triton+symmetric memory impl to verify the dynamic quant saving network bandwidth is actually an improvement in practice.

Copy link

pytorch-bot bot commented Sep 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3087

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4e57f18 with merge base b3b545f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2025
@danielvegamyhre danielvegamyhre added mx moe topic: not user facing Use this tag if you don't want this PR to show up in release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 27, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2025
@danielvegamyhre danielvegamyhre merged commit 0d3217d into main Sep 27, 2025
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. moe mx topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants