Replace param_group quantizer instance with QuantOptimizer attribute #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3104
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit abc60fd with merge base d407246 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
metascroy
reviewed
Oct 1, 2025
test/prototype/test_parq.py
Outdated
| def get_optim_kwargs(base_optimizer, embedding=True, quant_cls=UnifTorchaoQuantizer): | ||
| optim_kwargs = {} | ||
| if embedding: | ||
| group_idx = len(base_optimizer.param_groups) - 2 |
There was a problem hiding this comment.
Why this? It seems brittle?
There was a problem hiding this comment.
I agree—I just changed it to be more generalizable
lisjin
force-pushed
the
lvj/group-quantizer
branch
from
2fbb4a0 to
abc60fd
Compare
metascroy
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility with open source QAT training/finetuning scripts.
Details: FSDP2
state_dictandload_state_dictmethods will raise errors if param_group contains a quantizer object. (This is necessary for quantizing embeddings differently from other params.) I replaced theparam_group["quantizer"]key with agroup_quantizer_mapmapping betweenregularized_param_groupsindices and quantizers inQuantOptimizer.