-
Notifications
You must be signed in to change notification settings - Fork 342
make scale shape 2d and match qdata shape in NVFP4Tensor #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3108
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 08e9d13 with merge base 9368b28 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
need to fix swizzle slicing tests |
drisspg
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: improvement
Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Makes
NVFP4Tensor._scale_e4m3
shape be consistent withNVFP4Tensor.shape
. Specifically:(M, K)
corresponds to scale shape(M, K // 16)
(M, K)
corresponds to scale shape(ceil_div(M, 128) * 32, ceil_div(K, 64) * 16)
If we transpose axes 0 and 1, both qdata and scale now get transposed.
I want this because we need to reason about scales when combining 2d MoE weights into 3d weights, and having the scale shape match the data will make that reasoning easier (in a future PR).
Test Plan:
tests pass on a B200:
also, a dense model quantized with torchao nvfp4 runs in vLLM before and after this PR
Reviewers:
Subscribers:
Tasks:
Tags: