Skip to content

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Oct 9, 2025

Due to the recent version bump to python 3.10, and torch nightlies 2.10.0dev, rocm 6.3 has support errors. Minimum supported version is 7.0

Copy link

pytorch-bot bot commented Oct 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3136

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9396fc8 with merge base a5a8fe2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
@jainapurva jainapurva requested a review from jerryzh168 October 9, 2025 14:11
@jainapurva jainapurva added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 9, 2025
@jainapurva jainapurva requested a review from atalman October 9, 2025 15:42
@jainapurva
Copy link
Contributor Author

@jerryzh168 Sorry this fix might not be the best one, as Andrey mentioned that rocm7.0 is not supported by pytorch2.9

@jainapurva jainapurva changed the title Upgrade rocm from 6.3 to 7.0 for latest pytorch and python 3.10 Upgrade rocm CI Oct 9, 2025
@jainapurva jainapurva changed the title Upgrade rocm CI Fix rocm CI Oct 9, 2025
@jithunnair-amd
Copy link
Collaborator

@jerryzh168 Sorry this fix might not be the best one, as Andrey mentioned that rocm7.0 is not supported by pytorch2.9

Pytorch nightly wheels definitely support ROCm7.0: https://download.pytorch.org/whl/nightly/rocm7.0/

Is there a reason we can't use those?

@jagadish-amd Can you please work with @jainapurva to update the ROCm workflow?

@jagadish-amd
Copy link

@jerryzh168 Sorry this fix might not be the best one, as Andrey mentioned that rocm7.0 is not supported by pytorch2.9

Pytorch nightly wheels definitely support ROCm7.0: https://download.pytorch.org/whl/nightly/rocm7.0/

Is there a reason we can't use those?

@jagadish-amd Can you please work with @jainapurva to update the ROCm workflow?

The [build / build-manywheel-py3_10-rocm7_0] job was success earlier with
2025-10-09T22:23:17.7453622Z ++ export 'PIP_INSTALL_TORCH=pip install torch --pre --index-url https://download.pytorch.org/whl/nightly/rocm7.0'
We can verify if the test job passes with below config

    include:
      - name: ROCM Nightly
        runs-on: linux.rocm.gpu.gfx942.2
        torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/rocm7.0'
        gpu-arch-type: "rocm"
        gpu-arch-version: "7.0"
        docker-image: pytorch/manylinux2_28-builder:rocm7.0

@jainapurva
Copy link
Contributor Author

jainapurva commented Oct 10, 2025

@jerryzh168 Sorry this fix might not be the best one, as Andrey mentioned that rocm7.0 is not supported by pytorch2.9

Pytorch nightly wheels definitely support ROCm7.0: https://download.pytorch.org/whl/nightly/rocm7.0/
Is there a reason we can't use those?
@jagadish-amd Can you please work with @jainapurva to update the ROCm workflow?

The [build / build-manywheel-py3_10-rocm7_0] job was success earlier with 2025-10-09T22:23:17.7453622Z ++ export 'PIP_INSTALL_TORCH=pip install torch --pre --index-url https://download.pytorch.org/whl/nightly/rocm7.0' We can verify if the test job passes with below config

    include:
      - name: ROCM Nightly
        runs-on: linux.rocm.gpu.gfx942.2
        torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/rocm7.0'
        gpu-arch-type: "rocm"
        gpu-arch-version: "7.0"
        docker-image: pytorch/manylinux2_28-builder:rocm7.0

Yes, I tested the flow earlier, please refer to this commit, it was a success. Please let me know if I should just revert the PR to this commit, and remove all extra changes.

@jagadish-amd
Copy link

@jerryzh168 Sorry this fix might not be the best one, as Andrey mentioned that rocm7.0 is not supported by pytorch2.9

Pytorch nightly wheels definitely support ROCm7.0: https://download.pytorch.org/whl/nightly/rocm7.0/
Is there a reason we can't use those?
@jagadish-amd Can you please work with @jainapurva to update the ROCm workflow?

The [build / build-manywheel-py3_10-rocm7_0] job was success earlier with 2025-10-09T22:23:17.7453622Z ++ export 'PIP_INSTALL_TORCH=pip install torch --pre --index-url https://download.pytorch.org/whl/nightly/rocm7.0' We can verify if the test job passes with below config

    include:
      - name: ROCM Nightly
        runs-on: linux.rocm.gpu.gfx942.2
        torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/rocm7.0'
        gpu-arch-type: "rocm"
        gpu-arch-version: "7.0"
        docker-image: pytorch/manylinux2_28-builder:rocm7.0

Yes, I tested the flow earlier, please refer to this commit, it was a success. Please let me know if I should just revert the PR to this commit, and remove all extra changes.

yes, let's go with the commit which has 7.0 , thanks.

@jainapurva jainapurva merged commit c63899b into main Oct 10, 2025
19 checks passed
jainapurva added a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants