Fixing assert bug #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: we support handling fp32, fp16 and bf16 tensors with quantization, asserting we only handle bf16 was breaking things. Test Plan: python test/test.py -k "test_int8_dynamic_quant_subclass" Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
Merged
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: we support handling fp32, fp16 and bf16 tensors with quantization, asserting we only handle bf16 was breaking things. Test Plan: python test/test.py -k "test_int8_dynamic_quant_subclass" Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6fd2e01 Pull Request resolved: pytorch#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: we support handling fp32, fp16 and bf16 tensors with
quantization, asserting we only handle bf16 was breaking things.
Test Plan:
python test/test.py -k "test_int8_dynamic_quant_subclass"
Reviewers:
Subscribers:
Tasks:
Tags: