Skip to content

Conversation

astaff
Copy link
Contributor

@astaff astaff commented Feb 26, 2021

Question: I think the docstring is leaking Sphinx tags. Should we remove them?

@mthrok
Copy link
Contributor

mthrok commented Feb 26, 2021

Question: I think the docstring is leaking Sphinx tags. Should we remove them?

Where do you mean? The artifact looks good.
https://172095-90321822-gh.circle-artifacts.com/0/docs/backend.html

If you mean [wikipedia], [xiph.org] and other, they were residue from my copy-paste so we should remove it. Sorry about that.

@astaff
Copy link
Contributor Author

astaff commented Feb 26, 2021

spoke IRL: (1) revisit sphinx tags concern later. (2) removed links from docstring.

@mthrok
Copy link
Contributor

mthrok commented Feb 26, 2021

spoke IRL: (1) revisit sphinx tags concern later. (2) removed links from docstring.

[wikipedia] is still there. sorry...

@astaff
Copy link
Contributor Author

astaff commented Feb 26, 2021

Fixed.

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@mthrok mthrok merged commit 765fde0 into master Feb 26, 2021
@mthrok mthrok deleted the astaff-patch-1 branch February 26, 2021 22:14
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
* Delete static_quantization_tutorial.py

* Update index.rst
astaff pushed a commit to astaff/audio that referenced this pull request Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants