Skip to content

Notify merger of incorrectly labeled PRs #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

carolineechen
Copy link
Contributor

To make compilation of release notes easier for future releases, we will start using GitHub labels to label PRs with their associated primary (main) and secondary (subsection) labels. This PR is based on scripts from torchvision (here, here), and will notify the merger if a PR is merged without the proper labels via PR comment.

followups:

  • merge this PR w/o proper labels as a test
  • update torchaudio labels to reflect the finalized primary/secondary labels

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! CC @pmeier your script is getting popular :)

@carolineechen carolineechen merged commit 7e5f802 into pytorch:main Oct 28, 2021
@github-actions
Copy link

Hey @carolineechen!
You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/audio/blob/main/.github/process_commit.py

@carolineechen carolineechen deleted the require-pr-labels branch October 28, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants