Skip to content

Fix bandit failure #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Fix bandit failure #1960

merged 1 commit into from
Nov 2, 2021

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented Nov 2, 2021

No description provided.

@nateanl nateanl merged commit 6206d30 into pytorch:main Nov 2, 2021
try:
return subprocess.check_output(cmd).strip()
except Exception:
return None

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No try ~ except here. The purpose of the script is to purse, so if it cannot, it should stop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think you need decode("utf-8")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let me address it in the previous PR.

@nateanl nateanl deleted the fix_bandit branch November 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants