Skip to content

Revert "Change Tensor.data<T> to Tensor.data_ptr<T> (#261)" #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

Revert "Change Tensor.data<T> to Tensor.data_ptr<T> (#261)" #265

merged 1 commit into from
Sep 3, 2019

Conversation

vincentqb
Copy link
Contributor

Compilation error noticed in #262.

First PR to crash is #261 according to this. Unknown status from this.

This reverts commit 860edcd.

@vincentqb vincentqb requested a review from yf225 September 3, 2019 20:31
@vincentqb
Copy link
Contributor Author

vincentqb commented Sep 3, 2019 •
edited
Loading

@yf225 -- travis doesn't build with data_ptr, see here. Do we need to update something else also?

@vincentqb
Copy link
Contributor Author

master depends on pytorch 1.2.0, which doesn't have data_ptr yet.

yf225
yf225 approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Tensor.data_ptr<T>() doesn't exist in v1.2, so we will probably do it in the next release. :/

@vincentqb vincentqb self-assigned this Sep 3, 2019
@vincentqb vincentqb merged commit 962c6b0 into pytorch:master Sep 3, 2019
@vincentqb vincentqb deleted the revert-261 branch September 3, 2019 20:54
@vincentqb vincentqb mentioned this pull request Sep 3, 2019
Closed
vincentqb added a commit to vincentqb/audio that referenced this pull request Oct 23, 2019
@vincentqb
Revert "Revert "Change Tensor.data<T> to Tensor.data_ptr<T> (pytorch#261
2ac386c 
)" (pytorch#265)"

This reverts commit 962c6b0.
@vincentqb vincentqb mentioned this pull request Oct 23, 2019
Merged
vincentqb added a commit that referenced this pull request Oct 23, 2019
@vincentqb
Revert "Revert "Change Tensor.data<T> to Tensor.data_ptr<T> (#261)" (#…
5023bd2 
…265)" (#312)

This reverts commit 962c6b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yf225 yf225 yf225 approved these changes

Assignees

@vincentqb vincentqb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vincentqb @yf225