-
Notifications
You must be signed in to change notification settings - Fork 730
Modify installation instructions #4081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4081
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes FFmpeg related installation docs. There are still many references to ffmpeg in src and elsewhere (see grep -r -I --exclude "*~" -i ffmpeg .
). I think it would be clearer if all references/usages of ffmpeg are removed using a single PR.
Same note applies to other deleted features in torchaudio.
As far as occurances of 'ffmpeg' remaining, there's a couple in |
Most of the occurances of 'sox' you're seeing are for sox compatibility tests, which we want to preserve. What remains is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @samanklesaria!
This PR updates the installation instructions for each platform to remove references to ffmpeg.