Skip to content

Conversation

samanklesaria
Copy link
Collaborator

This PR updates the installation instructions for each platform to remove references to ffmpeg.

Copy link

pytorch-bot bot commented Sep 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4081

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 2, 2025
@samanklesaria samanklesaria marked this pull request as ready for review September 2, 2025 16:18
@samanklesaria samanklesaria requested a review from a team as a code owner September 2, 2025 16:18
Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes FFmpeg related installation docs. There are still many references to ffmpeg in src and elsewhere (see grep -r -I --exclude "*~" -i ffmpeg .). I think it would be clearer if all references/usages of ffmpeg are removed using a single PR.

Same note applies to other deleted features in torchaudio.

@samanklesaria
Copy link
Collaborator Author

As far as occurances of 'ffmpeg' remaining, there's a couple in .github/workflows, there's some lines in CMakelists, there's a smoke test (that I remember Nicholas advocating we keep for backward compatability), there's the torchcodec loading tests (which will be kept), and there's some flags for including parts of common_utils. I was planning on keeping this PR just about installation instructions. How about I make a second one for the CMakelist removals, common_utils flag removals, and github workflow removals?

@samanklesaria
Copy link
Collaborator Author

Most of the occurances of 'sox' you're seeing are for sox compatibility tests, which we want to preserve. What remains is:

  • A bunch of references to http://sox.sourceforge.net/sox.html in filtering.py which are just saying that the torchaudio function replications the functionality of a sox function.
  • The apply_codec function, which is deprecated and needs to be removed. I'll address this function in a separate PR.

Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @samanklesaria!

@pearu pearu requested a review from NicolasHug September 2, 2025 17:56
@samanklesaria samanklesaria merged commit 06d8284 into main Sep 2, 2025
24 of 25 checks passed
@samanklesaria samanklesaria deleted the modify_install_instructions branch September 2, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants