Skip to content

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Sep 3, 2025

As in title.

Previously, conda was installed from miniconda but that appears to be broken for Windows (I think start /wait .. is not effective to the miniconda installation processes and the scripts try to use conda while its installation process is still in progress).

Installing conda from miniforge works correctly, although, one must use curl -L .. to retrieve the installer, otherwise, its download will be broken.

Same as #4059 but this PR, as it was the case originally, does not use conda run ... commands.

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4085

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit a4d696e with merge base a059947 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 3, 2025
@pearu
Copy link
Collaborator Author

pearu commented Sep 3, 2025

Closing as the fix should land in #4059 .

@pearu pearu closed this Sep 3, 2025
@pearu pearu added this to the 2.9 milestone Sep 3, 2025
@pearu pearu reopened this Sep 4, 2025
@pearu pearu changed the title [DEBUG] setup_env.sh issue in activating conda environment [DEBUG] windows setup_env.sh issue in activating conda environment Sep 4, 2025
@pearu pearu changed the title [DEBUG] windows setup_env.sh issue in activating conda environment Use miniforge for conda and enable windows unit-testing in CI Sep 4, 2025
@pearu pearu marked this pull request as ready for review September 4, 2025 17:53
@pearu pearu requested a review from a team as a code owner September 4, 2025 17:53
@pearu pearu requested a review from samanklesaria September 4, 2025 17:53
Copy link
Collaborator

@samanklesaria samanklesaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pearu pearu merged commit 04487eb into pytorch:main Sep 5, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants