Skip to content

Conversation

samanklesaria
Copy link
Collaborator

Now that sox and ffmpeg are not part of torchaudio, we can remove these build flags from CMakeLists.

Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4100

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit bc655e6 with merge base fa51429 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 9, 2025
@samanklesaria samanklesaria marked this pull request as ready for review September 9, 2025 17:48
@samanklesaria samanklesaria requested a review from a team as a code owner September 9, 2025 17:48
Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @samanklesaria!

@pearu pearu added this to the 2.9 milestone Sep 10, 2025
@pearu pearu merged commit c1afcb9 into main Sep 10, 2025
45 of 49 checks passed
@pearu pearu deleted the remove_outdated_flags branch September 10, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants