Fix pyre error in _generate_baseline_single_dict_feature #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix the pyre error in `_generate_baseline_single_dict_feature` The issue was that the device parameter didn't have a type annotation. It appears that the correct type is torch.device. Also changed the call to `.to()` by adding the `device=` named parameter. If a named parameter is not used in this case, torch may assume this is a dtype (see: https://pytorch.org/docs/stable/generated/torch.Tensor.to.html). Adding the named parameter also clarifies the intent. Reviewed By: jjuncho Differential Revision: D65914877
|
This pull request was exported from Phabricator. Differential Revision: D65914877 |
|
This pull request has been merged in 49b1ed4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the pyre error in
_generate_baseline_single_dict_featureThe issue was that the device parameter didn't have a type annotation. It appears that the correct type is torch.device.
Also changed the call to
.to()by adding thedevice=named parameter. If a named parameter is not used in this case, torch may assume this is a dtype (see: https://pytorch.org/docs/stable/generated/torch.Tensor.to.html). Adding the named parameter also clarifies the intent.Reviewed By: jjuncho
Differential Revision: D65914877