Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in vision transformer - save class token and pos embedding #1204

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ManukyanD
Copy link
Contributor

@ManukyanD ManukyanD commented Dec 25, 2023

When saving model's learned parameters the class token and positional embedding parameters where not saved. This happened because these parameters where lost when moving the model to the GPU (as explained here). I guess this was the reason different tensors where returned when running with the same weights loaded from the saved model, as mentioned here.

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 14fb9c4
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/6589e10c5b01210008d7db96

@facebook-github-bot
Copy link
Contributor

Hi @ManukyanD!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@msaroufim msaroufim merged commit de85c09 into pytorch:main Jan 12, 2024
5 checks passed
@ManukyanD ManukyanD deleted the bugfix/vision-transformer branch January 12, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants