View op asserts should use non-fatal input checks

[GregoryComer]

🐛 Describe the bug

The current implementation of the view operator (et_view.cpp) uses ET_CHECK macros to check input args. This has the effect of unrecoverably crashing the process when input checks fail. We have observed this on an internal app, where a check failure causes a full app crash.

The kernel should use non-fatal ET_KERNEL_CHECK assertions (logging and returning an error code, rather than calling abort), similar to other portable ops. This allows the caller to gracefully handle model execution failures. See https://github.com/pytorch/executorch/pull/2115/files for an example of how other kernels were updated to use ET_KERNEL_CHECK instead of ET_CHECK macros.

Versions

N/A

cc @larryliu0820 @manuelcandales

[zhenyan-zhang-meta]

@GregoryComer

We have observed this on an internal app, where a check failure causes a full app crash.

Are there any examples that I can test on and prove that switching to ET_KERNEL_CHECK would work, or do I need to check?

[zhenyan-zhang-meta]

Have a pull request ready: #9264