-
Notifications
You must be signed in to change notification settings - Fork 670
Closed
Labels
actionableItems in the backlog waiting for an appropriate impl/fixItems in the backlog waiting for an appropriate impl/fixgood first issueGood for newcomersGood for newcomersmodule: build/installIssues related to the cmake and buck2 builds, and to installing ExecuTorchIssues related to the cmake and buck2 builds, and to installing ExecuTorch
Description
We currently build flatc from source, however we also:
- Allow people to bring their own flatc via the FLATC_EXECUTABLE flag
- Install flatc from pip for some builds
Given we rely on flatbuffers headers from the one we import, I think we should make this completely hermetic and always build flatc from source.
What are some reasons to allow bringing in flatc?
Metadata
Metadata
Assignees
Labels
actionableItems in the backlog waiting for an appropriate impl/fixItems in the backlog waiting for an appropriate impl/fixgood first issueGood for newcomersGood for newcomersmodule: build/installIssues related to the cmake and buck2 builds, and to installing ExecuTorchIssues related to the cmake and buck2 builds, and to installing ExecuTorch
Type
Projects
Status
Done