update extension of Bundled Program from .bp to .bpte (#787) #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for resplendent-gnome-14e531 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D50424792 |
Gasoonjia
force-pushed
the
export-D50424792
branch
from
8129092 to
7c35d09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50424792 |
Summary: as dbort's suggestion, update extension name to highlight to relationship between bundled program (.bpte) and ET program (.pte) This diff only focuses on updating extension in BundledProgram codebase, but not bp users' codebase. In the afterwards diffs, I will update the runtime apis to print warning message to tell users to store bp file in a proper file name. Reviewed By: JacobSzwejbka Differential Revision: D50424792
Gasoonjia
force-pushed
the
export-D50424792
branch
from
7c35d09 to
f6c1598
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50424792 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50424792 |
|
This pull request has been merged in e8d30ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
as dbort's suggestion, update extension name to highlight to relationship between bundled program (.bpte) and ET program (.pte)
This diff only focuses on updating extension in BundledProgram codebase, but not all places using bundled program and storing bp file using different extensions. In the afterwards diffs, I will update the runtime apis to print warning message to tell users to store bp file in a proper file name.
Differential Revision: D50424792