Skip to content

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Apr 14, 2025

Summary

ExecuTorch doc and repo have been successfully linked to the main entry on Hugging Face doc, now we need to link the Hugging Face doc and repo (huggingface/optimum-executorch) to ExecuTorch doc for seamless experience.

Test plan

Doc build on CI

@guangy10 guangy10 requested a review from mergennachin as a code owner April 14, 2025 20:27
Copy link

pytorch-bot bot commented Apr 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10154

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 13 Unrelated Failures

As of commit 07fdf9e with merge base 4ea6839 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2025
@guangy10 guangy10 requested review from GregoryComer, byjlw and mergennachin and removed request for mergennachin April 14, 2025 20:28
Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this. In the long-term, I'm thinking we should add an overview page on LLMs to discuss options, as well, but we can wait until we have the ETLLM and mobile runners figured out.

@guangy10
Copy link
Contributor Author

Looks good to me. Thanks for adding this. In the long-term, I'm thinking we should add an overview page on LLMs to discuss options, as well, but we can wait until we have the ETLLM and mobile runners figured out.

@GregoryComer Yeah, but note that Hugging Face models are not limited to LLMs, I'd like to get on to other models (diffusion, timm) asap once I can have a full story for various Transformers. So I intentionally avoid mentioning Transformers or LLMs in this PR.

@guangy10
Copy link
Contributor Author

rebase

@guangy10 guangy10 merged commit fa5d9c2 into main Apr 14, 2025
68 of 82 checks passed
@guangy10 guangy10 deleted the link_hf_docs branch April 14, 2025 22:46
@guangy10
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.6 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 14, 2025
### Summary
ExecuTorch doc and repo have been successfully linked to the main entry
on [Hugging Face
doc](https://huggingface.co/docs/optimum/main/en/index), now we need to
link the Hugging Face doc and repo
([`huggingface/optimum-executorch`](https://github.com/huggingface/optimum-executorch))
to ExecuTorch doc for seamless experience.

### Test plan
Doc build on CI

Co-authored-by: Guang Yang <guangyang@fb.com>
(cherry picked from commit fa5d9c2)
@pytorchbot
Copy link
Collaborator

Cherry picking #10154

The cherry pick PR is at #10171 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
### Summary
ExecuTorch doc and repo have been successfully linked to the main entry
on [Hugging Face
doc](https://huggingface.co/docs/optimum/main/en/index), now we need to
link the Hugging Face doc and repo
([`huggingface/optimum-executorch`](https://github.com/huggingface/optimum-executorch))
to ExecuTorch doc for seamless experience.

### Test plan
Doc build on CI

Co-authored-by: Guang Yang <guangyang@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants