Skip to content

Conversation

kirklandsign
Copy link
Contributor

This helps users locate their AAR file.

@kirklandsign kirklandsign requested a review from Copilot April 14, 2025 23:24
Copy link

pytorch-bot bot commented Apr 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10174

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2025
@kirklandsign kirklandsign marked this pull request as ready for review April 14, 2025 23:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

extension/android/README.md:33

  • There is an inconsistency between the AAR file names mentioned in the documentation. The file built is named 'executorch_android-debug.aar' (line 31) while the instructions refer to 'executorch.aar'. Please clarify if the file is renamed during the copy process or update the documentation for consistency.
Later, you can copy `$BUILD_AAR_DIR/executorch.aar` to your app directory to use as a library.

@kirklandsign kirklandsign requested a review from Copilot April 14, 2025 23:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@kirklandsign kirklandsign merged commit 59cbd80 into main Apr 15, 2025
77 of 79 checks passed
@kirklandsign kirklandsign deleted the aar-out branch April 15, 2025 01:20
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
This helps users locate their AAR file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants