Remove #include <span> #10533
Merged
Remove #include <span> #10533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove span.h. Seems like it is not needed. Also part of C++20, not 17, which caused some errors when I was building et tests locally. ``` error: 10:10: fatal error: span: No such file or directory 10 | #include <span> | ^~~~~~ compilation terminated. gmake\[2\]: \*\*\* \[runtime79: runtime/core/test/CMakeFiles/runtime\_core\_test.dir/span\_test.cpp.o\] Error 1 gmake\[1\]: \*\*\* \[CMakeFiles5899: runtime/core/test/CMakeFiles/runtime\_core\_test.dir/all\] Error 2 gmake\[1\]: \*\*\* Waiting for unfinished jobs.... ``` Differential Revision: [D73810585](https://our.internmc.facebook.com/intern/diff/D73810585/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 28, 2025
Remove span.h. Seems like it is not needed. Also part of C++20, not 17, which caused some errors when I was building et tests locally. ``` error: 10:10: fatal error: span: No such file or directory 10 | #include <span> | ^~~~~~ compilation terminated. gmake\[2\]: \*\*\* \[runtime79: runtime/core/test/CMakeFiles/runtime\_core\_test.dir/span\_test.cpp.o\] Error 1 gmake\[1\]: \*\*\* \[CMakeFiles5899: runtime/core/test/CMakeFiles/runtime\_core\_test.dir/all\] Error 2 gmake\[1\]: \*\*\* Waiting for unfinished jobs.... ``` Differential Revision: [D73810585](https://our.internmc.facebook.com/intern/diff/D73810585/) ghstack-source-id: 280789075 Pull Request resolved: #10533
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10533
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 10 Pending, 1 Unrelated FailureAs of commit d09a945 with merge base df75088 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73810585 |
JacobSzwejbka
approved these changes
Apr 28, 2025
swolchok
approved these changes
Apr 28, 2025
facebook-github-bot
merged commit f7ed0f4
into
gh/lucylq/73/base
83 of 89 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Apr 29, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10533 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/73/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/73/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/73/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Remove # include span
Seems like it is not needed. Also part of C++20, not 17, which caused some errors when I was building et tests locally.
Differential Revision: D73810585