Skip to content

Qualcomm AI Engine Direct - xr model enablement (mld_f) #10546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Qualcomm AI Engine Direct - xr model enablement (mld_f) #10546

merged 3 commits into from
May 23, 2025

Conversation

haowhsu-quic
Copy link
Collaborator

Summary

  • add gather op support
  • make cast / slice op more general

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10546

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f1d79f5 with merge base ed718a8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2025
@haowhsu-quic haowhsu-quic force-pushed the dev_mld_f branch 3 times, most recently from 4b24a82 to a475672 Compare May 2, 2025 05:16
@haowhsu-quic haowhsu-quic marked this pull request as ready for review May 7, 2025 03:42
@haowhsu-quic haowhsu-quic requested a review from cccclai as a code owner May 7, 2025 03:42
@haowhsu-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label May 7, 2025
@haowhsu-quic
Copy link
Collaborator Author

Hi @cccclai, this PR is for XR model enablement, could you help review on this? Thank you!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cccclai
cccclai approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@cccclai
Copy link
Contributor

cccclai commented May 21, 2025

Sorry for keep you waiting, since the CI was red for a few weeks, we didn't land PRs during this time. We should be good to resume it now.

@haowhsu-quic
Qualcomm AI Engine Direct - xr model enablement (mld_f)
02001bf 
Summary
- add gather op support
- make cast logic / slice op more general
@haowhsu-quic
add test coverage of cast op
dca006f
@haowhsu-quic
Copy link
Collaborator Author

Sorry for keep you waiting, since the CI was red for a few weeks, we didn't land PRs during this time. We should be good to resume it now.

Thank you!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 49805bd into pytorch:main May 23, 2025
89 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billmguo billmguo billmguo approved these changes

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haowhsu-quic @facebook-github-bot @cccclai @billmguo