Skip to content

Conversation

wwwind
Copy link
Collaborator

@wwwind wwwind commented May 6, 2025

Add pass to decompose cosine_similarity op so that it is annotated for BI profile + tests + enable disabled test in test_nn_functional.py for cosine_similarity.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Add pass to decompose cosine_similarity op so that it is annotated
for BI profile + tests + enable disabled test in test_nn_functional.py
for cosine_similarity.

Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
Change-Id: I1c03596336004ccbd322f68bd1a17cc15458b563
@wwwind wwwind requested a review from digantdesai as a code owner May 6, 2025 17:11
Copy link

pytorch-bot bot commented May 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10729

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4de1c0b with merge base 14586f9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2025
@wwwind wwwind added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 6, 2025
@wwwind wwwind requested a review from zingo May 6, 2025 18:54
@zingo zingo merged commit 64c4b33 into pytorch:main May 7, 2025
174 of 178 checks passed
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
Add pass to decompose cosine_similarity op so that it is annotated for
BI profile + tests + enable disabled test in test_nn_functional.py for
cosine_similarity.

Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants