[CMake] Avoid extension_module have dupe flat_tensor cpp #10735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, _extension_module__srcs has srcs from flat_tensor. This is
bad.
```
set(_extension_module__srcs
extension/flat_tensor/flat_tensor_data_map.cpp
extension/flat_tensor/serialize/flat_tensor_header.cpp
extension/module/module.cpp
)
```
We need to update deps. We need to export extension_flat_tensor to
install directory.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10735
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9bdca39 with merge base 304c567 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
ciflow/trunk
ciflow/binaries
and removed
CLA Signed
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
the
release notes: build
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
requested review from
manuelcandales,
swolchok and
jackzhxng
as code owners
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
Differential Revision: D74278030 Pull Request resolved: pytorch#10735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, _extension_module__srcs has srcs from flat_tensor. This is bad.
We need to update deps. We need to export extension_flat_tensor to install directory.