Arm backend: Replace asserts with ValueError for slicing constraints #10748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code used assertions to validate slicing parameters (e.g., size must be positive and within dimension limits). This has been changed to raise ValueError with descriptive error messages to provide clearer feedback and robustness for invalid inputs when using aten.slice_copy.Tensor. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Change-Id: If09bbe2e9e2b0fb1ddbfb3cd64ff2aa99f0dffe4
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10748
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 1e5c141 with merge base 1984c5f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
CI failure ".github/workflows/build-presets.yml (gh)" seems unrelated. I see it in other PRs as well |
zingo
approved these changes
May 7, 2025
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
…ytorch#10748) The existing code used assertions to validate slicing parameters (e.g., size must be positive and within dimension limits). This has been changed to raise ValueError with descriptive error messages to provide clearer feedback and robustness for invalid inputs when using aten.slice_copy.Tensor. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code used assertions to validate slicing parameters (e.g., size must be positive and within dimension limits). This has been changed to raise ValueError with descriptive error messages to provide clearer feedback and robustness for invalid inputs when using aten.slice_copy.Tensor.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218