Skip to content

Conversation

tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented May 7, 2025

  • MaxPool2dVisitor will adjust padding if the pooling window is not divisible by the stride

Change-Id: I92c4f714067b8498f4df328dc971991a2585ec6c

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

… stride

* MaxPool2dVisitor will adjust padding if the pooling window is not divisible by the stride

Signed-off-by: Tom Allsop <tom.allsop@arm.com>
Change-Id: I92c4f714067b8498f4df328dc971991a2585ec6c
@tom-arm tom-arm requested a review from digantdesai as a code owner May 7, 2025 15:59
Copy link

pytorch-bot bot commented May 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10751

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9676708 with merge base cebe051 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2025
@tom-arm tom-arm added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels May 7, 2025
@zingo
Copy link
Collaborator

zingo commented May 7, 2025

Fail is unrelated and happens in other PRs

@zingo zingo merged commit 8ee9f91 into pytorch:main May 7, 2025
174 of 177 checks passed
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
… stride (pytorch#10751)

* MaxPool2dVisitor will adjust padding if the pooling window is not divisible by the stride


Signed-off-by: Tom Allsop <tom.allsop@arm.com>
@tom-arm tom-arm deleted the maxpool2d_adjust_padding branch May 12, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants