Skip to content

Move EXECUTORCH_LOG_LEVEL to default preset #10799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Move EXECUTORCH_LOG_LEVEL to default preset #10799

merged 1 commit into from
May 12, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 10, 2025 •
edited
Loading

Summary

TSIA

Test plan

CI +

$ cmake --preset macos-arm64 && cmake --build cmake-out --parallel

$ cmake -DEXECUTORCH_LOG_LEVEL=fake --preset macos-arm64

CMake Error at tools/cmake/preset/default.cmake:65 (message):
  Unknown EXECUTORCH_LOG_LEVEL 'fake'.  Choices: Debug, Info, Error, Fatal
Call Stack (most recent call first):
  CMakeLists.txt:53 (include)

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 10, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10799

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 24 Pending

As of commit acf813c with merge base e113c00 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2025
@jathu jathu force-pushed the jathu/move-EXECUTORCH_LOG_LEVEL branch 2 times, most recently from 5ead4b6 to 5a8e1b2 Compare May 10, 2025 23:21
@jathu jathu force-pushed the jathu/move-EXECUTORCH_PAL_DEFAULT branch 2 times, most recently from 8ab14d7 to 83be7d3 Compare May 12, 2025 16:31
@jathu jathu force-pushed the jathu/move-EXECUTORCH_LOG_LEVEL branch from 5a8e1b2 to 72ed283 Compare May 12, 2025 16:33
@jathu jathu marked this pull request as ready for review May 12, 2025 16:51
Base automatically changed from jathu/move-EXECUTORCH_PAL_DEFAULT to main May 12, 2025 17:48
@jathu jathu force-pushed the jathu/move-EXECUTORCH_LOG_LEVEL branch from 72ed283 to acf813c Compare May 12, 2025 17:49
@jathu jathu merged commit 42b55f4 into main May 12, 2025
196 checks passed
@jathu jathu deleted the jathu/move-EXECUTORCH_LOG_LEVEL branch May 12, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jathu @kirklandsign @facebook-github-bot