Skip to content

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 10, 2025

Summary

TSIA

Test plan

$ cmake --preset macos-arm64 && cmake --build cmake-out --parallel
$ cmake -DEXECUTORCH_ENABLE_EVENT_TRACER=ON --preset macos-arm64 && cmake --build cmake-out --parallel

CMake Error at tools/cmake/preset/default.cmake:82 (message):
  Use of 'EXECUTORCH_ENABLE_EVENT_TRACER' requires
  'EXECUTORCH_BUILD_DEVTOOLS' to be enabled.
Call Stack (most recent call first):
  CMakeLists.txt:53 (include)
$ cmake -DEXECUTORCH_ENABLE_EVENT_TRACER=ON -DEXECUTORCH_BUILD_DEVTOOLS=ON --preset macos-arm64 && cmake --build cmake-out --parallel

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 10, 2025
Copy link

pytorch-bot bot commented May 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10801

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Pending

As of commit c2c9a6b with merge base 27e159e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2025
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from f84da20 to 6daeedc Compare May 10, 2025 23:41
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION branch from 2e5c610 to 836b7eb Compare May 12, 2025 16:38
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from 6daeedc to 8c113c5 Compare May 12, 2025 16:39
@jathu jathu marked this pull request as ready for review May 12, 2025 16:51
@jathu jathu requested review from digantdesai and mcr229 as code owners May 12, 2025 16:51
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION branch from 836b7eb to a0291de Compare May 12, 2025 19:34
Base automatically changed from jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION to main May 12, 2025 20:48
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from 8c113c5 to daa4e4a Compare May 12, 2025 21:00
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from daa4e4a to c2c9a6b Compare May 12, 2025 21:50
@jathu jathu added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed topic: not user facing labels May 12, 2025
@jathu jathu merged commit 4a738bd into main May 12, 2025
192 of 198 checks passed
@jathu jathu deleted the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch May 12, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants