Skip to content

Delete EXECUTORCH_BUILD_ANDROID_JNI #10803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Delete EXECUTORCH_BUILD_ANDROID_JNI #10803

merged 1 commit into from
May 13, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 10, 2025 •
edited by pytorch-bot bot
Loading

Summary

Seems like this isn't used anywhere.

Test plan

$ rg EXECUTORCH_BUILD_ANDROID_JNI --hidden

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 10, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10803

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2025
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from 5202dad to 3af82b7 Compare May 12, 2025 16:42
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from bbd11ec to 8a1e262 Compare May 12, 2025 16:43
@jathu jathu marked this pull request as ready for review May 12, 2025 16:52
kirklandsign
kirklandsign approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from 3af82b7 to fb15c25 Compare May 12, 2025 21:01
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from 8a1e262 to bc0910d Compare May 12, 2025 21:02
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from fb15c25 to 3abc792 Compare May 12, 2025 21:51
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from bc0910d to 4244eaf Compare May 12, 2025 21:51
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from 3abc792 to 70387e5 Compare May 12, 2025 23:16
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from 4244eaf to d1774d3 Compare May 12, 2025 23:17
Base automatically changed from jathu/move-OPTIMIZE_SIZE to main May 13, 2025 00:15
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from d1774d3 to 1afd0e3 Compare May 13, 2025 00:16
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@jathu jathu merged commit 756f86a into main May 13, 2025
106 of 111 checks passed
@jathu jathu deleted the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch May 13, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin

@digantdesai digantdesai Awaiting requested review from digantdesai

@mcr229 mcr229 Awaiting requested review from mcr229

Assignees
No one assigned
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jathu @kirklandsign @facebook-github-bot