Skip to content

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 11, 2025

Summary

  • Move the simple options to default preset. This shouldn't change any build configurations
  • Rename BUILD_EXECUTORCH_PORTABLE_OPS to EXECUTORCH_BUILD_PORTABLE_OPS

Test plan

CI

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 11, 2025
Copy link

pytorch-bot bot commented May 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10804

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 81af638 with merge base 756f86a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2025
@jathu jathu force-pushed the jathu/move-simple-option branch 3 times, most recently from 9283d7b to 6eebdd1 Compare May 11, 2025 00:11
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from bbd11ec to 8a1e262 Compare May 12, 2025 16:43
@jathu jathu force-pushed the jathu/move-simple-option branch from 6eebdd1 to 3434d78 Compare May 12, 2025 16:56
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from 8a1e262 to bc0910d Compare May 12, 2025 21:02
@jathu jathu force-pushed the jathu/move-simple-option branch from 3434d78 to f375589 Compare May 12, 2025 21:03
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from bc0910d to 4244eaf Compare May 12, 2025 21:51
@jathu jathu force-pushed the jathu/move-simple-option branch from f375589 to fe3c2ec Compare May 12, 2025 21:51
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from 4244eaf to d1774d3 Compare May 12, 2025 23:17
@jathu jathu force-pushed the jathu/move-simple-option branch from fe3c2ec to c7a6437 Compare May 12, 2025 23:17
@jathu jathu marked this pull request as ready for review May 13, 2025 00:07
@jathu jathu requested a review from tarun292 as a code owner May 13, 2025 00:07
@jathu jathu added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed topic: not user facing labels May 13, 2025
@jathu jathu force-pushed the jathu/move-EXECUTORCH_BUILD_ANDROID_JNI branch from d1774d3 to 1afd0e3 Compare May 13, 2025 00:16
@jathu jathu requested a review from mergennachin as a code owner May 13, 2025 00:16
Base automatically changed from jathu/move-EXECUTORCH_BUILD_ANDROID_JNI to main May 13, 2025 00:17
@jathu jathu force-pushed the jathu/move-simple-option branch from c7a6437 to 81af638 Compare May 13, 2025 00:18
@jathu jathu merged commit 473c77b into main May 13, 2025
192 of 196 checks passed
@jathu jathu deleted the jathu/move-simple-option branch May 13, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants