-
Notifications
You must be signed in to change notification settings - Fork 683
Example external model to be used by the ahead of time arm compiler #10810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10810
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New Failures, 4 Unrelated FailuresAs of commit 3d100d7 with merge base a21022c ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "partner: arm" |
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice patch looks great! Thanks. I just have a small request if it's OK?
As its only Arm that support this thing right now would it be OK to move the files to examples/arm/
e.g. from
examples/models/example_export_from_module
to
examples/arm/examples
or
examples/arm/example_modules
or keep the longer folder name if you like.
And as we probably will add a few more test models down the line maybe rename it from model.py to model_add.py (or add.py ) ?
Thanks for the help!
Thanks for the update! |
All the llama test errors are unrelated and seen in other PRs right now. |
@Juanfi8 Almost ready to merge :) lintrunner --force-color --all-files --tee-json=lint.json
Warning (UFMT) format
|
I hope this time is the one :) |
Great work! |
Example of an external model to be loaded as a module by the aot_arm_compiler.py.
Useful for documentation.
@zingo
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218