Arm backend: Update partitioner de-tagging iteration order #10813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When de-tagging tagged/partitioned nodes, the order in which we iterate the nodes will matter as each node will make a decision based on if the parent node is partitoned or has a compatible dtype. This change makes sure we iterate the nodes in the order of the original graph_module. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I0e77c20440fee52f50cb1b7e57d8c39789b4f3c5
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10813
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7c9b63d with merge base 65d931e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
zingo
approved these changes
May 12, 2025
oscarandersson8218
added
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When de-tagging tagged/partitioned nodes, the order in which we iterate the nodes will matter as each node will make a decision based on if the parent node is partitoned or has a compatible dtype. This change makes sure we iterate the nodes in the order of the original graph_module.
cc @digantdesai @freddan80 @per @zingo