Skip to content

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented May 12, 2025

When de-tagging tagged/partitioned nodes, the order in which we iterate the nodes will matter as each node will make a decision based on if the parent node is partitoned or has a compatible dtype. This change makes sure we iterate the nodes in the order of the original graph_module.

cc @digantdesai @freddan80 @per @zingo

When de-tagging tagged/partitioned nodes, the order in which we iterate
the nodes will matter as each node will make a decision based on if the
parent node is partitoned or has a compatible dtype. This change makes
sure we iterate the nodes in the order of the original graph_module.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I0e77c20440fee52f50cb1b7e57d8c39789b4f3c5
Copy link

pytorch-bot bot commented May 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10813

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7c9b63d with merge base 65d931e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 12, 2025
@oscarandersson8218 oscarandersson8218 added release notes: none Do not include this in the release notes and removed topic: not user facing labels May 13, 2025
@zingo zingo merged commit 7993bb2 into pytorch:main May 13, 2025
182 of 184 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants