Skip to content

Update CI for HF Optimum models #10820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Update CI for HF Optimum models #10820

merged 1 commit into from
May 14, 2025

Conversation

guangy10
Copy link
Contributor

Summary

Updated pinned optimum-executorch. Use optimum-cli to generate pte files with xnnpack+custom_sdpa+8da4w. Getting the CI ready to be profiling those ptes using executor_runner.

Test plan

CI will export native HF models via optimum-cli and validate those models via python API from_pretrained.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10820

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2025
@guangy10 guangy10 force-pushed the update_ci_optimum_models branch 2 times, most recently from fac9438 to 49560eb Compare May 12, 2025 21:50
@guangy10 guangy10 force-pushed the update_ci_optimum_models branch from 49560eb to fc92a31 Compare May 12, 2025 22:19
@guangy10 guangy10 added release notes: none Do not include this in the release notes and removed topic: not user facing labels May 12, 2025
kimishpatel
kimishpatel reviewed May 12, 2025
View reviewed changes
@guangy10 guangy10 force-pushed the update_ci_optimum_models branch 4 times, most recently from 1347341 to 4e99ae7 Compare May 13, 2025 00:34
@guangy10
Copy link
Contributor Author

guangy10 commented May 13, 2025 •
edited
Loading

@huydhn Do you have any idea about this error when uploading artifacts to GitHub?

With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

https://github.com/pytorch/executorch/actions/runs/14986846414/job/42102276419?pr=10820#step:21:115

@guangy10 guangy10 force-pushed the update_ci_optimum_models branch 7 times, most recently from 0646517 to 90e7826 Compare May 13, 2025 20:36
guangy10
guangy10 commented May 13, 2025
View reviewed changes
.github/workflows/trunk.yml Outdated
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 90
upload-artifact: profiling-artifacts
upload-artifact-to-s3: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload to S3 can upload all artifacts from all jobs without name collision, however, it doesn't show me the URL to download. https://github.com/pytorch/executorch/actions/runs/15006249421/job/42165486798?pr=10820#step:22:119

Upload to GitHub will end up with name collision https://github.com/pytorch/executorch/actions/runs/15003586551/job/42156514855#step:21:116. There is only one artifact can be uploaded successfully with URL to download https://github.com/pytorch/executorch/actions/runs/15003586551/job/42156514884#step:21:123

cc: @huydhn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To unblock this PR, the workaround is to use job-index to make the upload-artifact name unique

@guangy10 guangy10 force-pushed the update_ci_optimum_models branch from 90e7826 to 808360b Compare May 13, 2025 22:40
@guangy10 guangy10 merged commit 62cf849 into main May 14, 2025
179 of 181 checks passed
@guangy10 guangy10 deleted the update_ci_optimum_models branch May 14, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guangy10 @kimishpatel @kirklandsign @facebook-github-bot