Skip to content

Default to file load mode in module #10827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Default to file load mode in module #10827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extension/module/module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Module {
*/
explicit Module(
const std::string& file_path,
const LoadMode load_mode = LoadMode::MmapUseMlock,
const LoadMode load_mode = LoadMode::File,
std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);

/**
Expand All @@ -68,7 +68,7 @@ class Module {
explicit Module(
const std::string& file_path,
const std::string& data_map_path,
const LoadMode load_mode = LoadMode::MmapUseMlock,
const LoadMode load_mode = LoadMode::File,
std::unique_ptr<runtime::EventTracer> event_tracer = nullptr);

/**
Expand Down Expand Up @@ -481,7 +481,7 @@ class Module {

std::string file_path_;
std::string data_map_path_;
LoadMode load_mode_{LoadMode::MmapUseMlock};
LoadMode load_mode_{LoadMode::File};
std::shared_ptr<Program> program_;
std::unique_ptr<runtime::DataLoader> data_loader_;
std::unique_ptr<runtime::MemoryAllocator> memory_allocator_;
Expand Down
Loading