Arm backend: Decompose sum in pass #10852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the unrolling of reducing multiple indices from the sum node visitor to a new DecomposeSumPass. KeepDimsFalseToSqueezePass is merged into the new pass to decompose the sum op fully in one pass. This change introduces new rescales for each reduced dim, requiring decomposition before quantization to get proper quantization parameters. Change-Id: I1b113813f22c6b25aac56d63110d7eee4833167a Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
AdrianLundell
added
ciflow/trunk
topic: not user facing
release notes: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10852
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit a113625 with merge base dcd25eb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Unrelated errors, flaky tests not touched by this patch and bad downloads. |
zingo
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the unrolling of reducing multiple indices
from the sum node visitor to a new DecomposeSumPass.
KeepDimsFalseToSqueezePass is merged into the new
pass to decompose the sum op fully in one pass.
This change introduces new rescales for each
reduced dim, requiring decomposition before quantization to get proper quantization parameters.