Skip to content

Conversation

mcremon-meta
Copy link
Contributor

Summary: The scalar mul can be folded into the dequant args. Motivating example: vit_b_16 shows that pattern, resulting in 1% less latency (30k cycles).

Differential Revision: D74626626

@mcremon-meta mcremon-meta requested a review from tarun292 as a code owner May 13, 2025 15:00
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74626626

Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10853

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 9 New Failures, 4 Unrelated Failures

As of commit 0e816b4 with merge base a21022c (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta added a commit that referenced this pull request May 14, 2025
Summary:

The scalar mul can be folded into the dequant args. Motivating example: `vit_b_16` shows that pattern, resulting in 1% less latency (30k cycles).

Differential Revision: D74626626
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74626626

mcremon-meta added a commit that referenced this pull request May 14, 2025
Summary:
Pull Request resolved: #10853

The scalar mul can be folded into the dequant args. Motivating example: `vit_b_16` shows that pattern, resulting in 1% less latency (30k cycles).

Differential Revision: D74626626
mcremon-meta added a commit that referenced this pull request May 14, 2025
Summary:

The scalar mul can be folded into the dequant args. Motivating example: `vit_b_16` shows that pattern, resulting in 1% less latency (30k cycles).

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D74626626
Summary:
Pull Request resolved: #10853

The scalar mul can be folded into the dequant args. Motivating example: `vit_b_16` shows that pattern, resulting in 1% less latency (30k cycles).

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D74626626
@mcremon-meta mcremon-meta added the release notes: none Do not include this in the release notes label May 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74626626

@facebook-github-bot facebook-github-bot merged commit 12b5eb6 into main May 14, 2025
73 of 88 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D74626626 branch May 14, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants