Skip to content

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 13, 2025

Summary

I came across this "cleaner" approach when setting up flatcc (#10855). So, let's do it for flatc too.

Test plan

CI

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 13, 2025
Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10859

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 2192226 with merge base 518324f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@jathu jathu force-pushed the jathu/install-flatc-fix branch from ebfd1f1 to 6c28cff Compare May 13, 2025 21:04
@jathu jathu force-pushed the jathu/install-flatc-fix branch from 6c28cff to 2192226 Compare May 13, 2025 21:11
@jathu jathu marked this pull request as ready for review May 13, 2025 21:20
@jathu jathu merged commit b20419d into main May 13, 2025
201 of 202 checks passed
@jathu jathu deleted the jathu/install-flatc-fix branch May 13, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants