-
Notifications
You must be signed in to change notification settings - Fork 685
Enable OSS coreml python tests #10975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10975
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 362265c with merge base 5200778 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Only concern is mac env tests are expensive, but obviously testing stuff like this is what they are for. |
--ignore=backends/xnnpack/test/ops/test_sdpa.py | ||
backends/xnnpack/test/passes | ||
backends/xnnpack/test/serialization | ||
# backends/apple/coreml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: delete
# backends/apple/coreml |
backends/xnnpack/test/passes | ||
backends/xnnpack/test/serialization | ||
# backends/apple/coreml | ||
backends/apple/coreml/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail on non-Apple platforms. We need to see if we can selectively include this only on macOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jathu yeah, I saw this in the CI failures. Is there currently a good way to specify this granularity in ET's testing framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try adding a --ignore
option for linux here:
As titled