Skip to content

Conversation

metascroy
Copy link
Contributor

As titled

Copy link

pytorch-bot bot commented May 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10975

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 362265c with merge base 5200778 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2025
@metascroy metascroy requested a review from shoumikhin May 19, 2025 17:20
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka
Copy link
Contributor

Only concern is mac env tests are expensive, but obviously testing stuff like this is what they are for.

--ignore=backends/xnnpack/test/ops/test_sdpa.py
backends/xnnpack/test/passes
backends/xnnpack/test/serialization
# backends/apple/coreml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: delete

Suggested change
# backends/apple/coreml

backends/xnnpack/test/passes
backends/xnnpack/test/serialization
# backends/apple/coreml
backends/apple/coreml/test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail on non-Apple platforms. We need to see if we can selectively include this only on macOS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jathu yeah, I saw this in the CI failures. Is there currently a good way to specify this granularity in ET's testing framework?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metascroy metascroy merged commit 7b1374c into main May 30, 2025
190 of 191 checks passed
@metascroy metascroy deleted the enable-coreml-tests branch May 30, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants