Implement index_put inplace #10996
Merged
Implement index_put inplace #10996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10996
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ee3c602 with merge base 936ac2b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74765433 |
manuelcandales
added
the
release notes: ops & kernels
JacobSzwejbka
approved these changes
May 20, 2025
|
|
||
| } // namespace | ||
|
|
||
| Tensor& index_put_( |
There was a problem hiding this comment.
is it worth making the out variant call the inplace one on out?
manuelcandales
force-pushed
the
export-D74765433
branch
from
5dc5801 to
cf38197
Compare
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#10996 Reviewed By: JacobSzwejbka Differential Revision: D74765433
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#10996 Reviewed By: JacobSzwejbka Differential Revision: D74765433
manuelcandales
force-pushed
the
export-D74765433
branch
from
cf38197 to
f7223a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74765433 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D74765433 |
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#10996 Reviewed By: JacobSzwejbka Differential Revision: D74765433
manuelcandales
force-pushed
the
export-D74765433
branch
from
f7223a2 to
9b0e776
Compare
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#10996 Reviewed By: JacobSzwejbka Differential Revision: D74765433
manuelcandales
force-pushed
the
export-D74765433
branch
from
9b0e776 to
53118f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74765433 |
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: pytorch#10996 Reviewed By: JacobSzwejbka Differential Revision: D74765433
manuelcandales
force-pushed
the
export-D74765433
branch
from
53118f1 to
ee70769
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74765433 |
Summary: Pull Request resolved: pytorch#10996 Reviewed By: JacobSzwejbka Differential Revision: D74765433
manuelcandales
force-pushed
the
export-D74765433
branch
from
ee70769 to
ee3c602
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74765433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D74765433