Skip to content

Fix crash #11096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Fix crash #11096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...n/android/executorch_android/src/androidTest/java/org/pytorch/executorch/ModuleE2ETest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ class ModuleE2ETest {

val module = Module.load(getTestFilePath("/mv3_xnnpack_fp32.pte"))
val expectedBackends = arrayOf("XnnpackBackend")
Assert.assertArrayEquals(
expectedBackends,
module.getMethodMetadata("forward").getBackends(),
)
}

@Test
Expand Down
3 changes: 0 additions & 3 deletions ...ecutorch_android/src/androidTest/java/org/pytorch/executorch/ModuleInstrumentationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ class ModuleInstrumentationTest {
@Throws(IOException::class, URISyntaxException::class)
fun testMethodMetadata() {
val module = Module.load(getTestFilePath(TEST_FILE_NAME))

Assert.assertArrayEquals(arrayOf("forward"), module.getMethods())
Assert.assertTrue(module.getMethodMetadata("forward").backends.isEmpty())
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion extension/android/executorch_android/src/main/java/org/pytorch/executorch/Module.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Map<String, MethodMetadata> populateMethodMeta() {
Map<String, MethodMetadata> metadata = new HashMap<String, MethodMetadata>();
for (int i = 0; i < methods.length; i++) {
String name = methods[i];
metadata.put(name, new MethodMetadata().setName(name).setBackends(getUsedBackends(name)));
metadata.put(name, new MethodMetadata().setName(name));
}

return metadata;
Expand Down
Loading