Skip to content

Conversation

phaiting
Copy link
Contributor

Summary

This change did two changes:

  • Use lateinit var to remove !!
  • Created a common TestFileUtils to share the same code for getTestFilePath across all instrumentation test code.

Test plan

./gradlew :executorch_android:connectedAndroidTest

@phaiting phaiting requested a review from kirklandsign as a code owner May 27, 2025 19:50
Copy link

pytorch-bot bot commented May 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11155

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 69eb83d with merge base 0cf2d53 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2025
@phaiting
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 27, 2025
@phaiting phaiting merged commit 7b53b88 into main May 30, 2025
93 of 97 checks passed
@phaiting phaiting deleted the update-e2e-test branch May 30, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants