Skip to content

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 27, 2025

Summary

Fixes a bug where we return too early since we are using a macro. This is only apparent if set_overridable_option is used outside of a top-level CMake file (i.e. different scope)

Test plan

unittest + CI

Copy link

pytorch-bot bot commented May 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11156

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit de41306 with merge base 0cf2d53 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2025
@jathu jathu added ciflow/trunk release notes: none Do not include this in the release notes labels May 27, 2025
@jathu jathu marked this pull request as ready for review May 27, 2025 20:54
@jathu jathu merged commit 8b95d9e into main May 27, 2025
201 of 206 checks passed
@jathu jathu deleted the jathu/fix-set branch May 27, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants