Update cpuinfo utils to account for apple soc detection #11268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11268
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 62a9af2 with merge base 9f74777 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@kimishpatel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kimishpatel
added
the
release notes: none
Summary: For macbooks it also takes the path of just querying perfcores which should actually work for ios as well. Test Plan: Use internal util and validate the behavior is as expected Reviewers: Subscribers: Tasks: Tags:
kimishpatel
force-pushed
the
update_cpuinfo_utils
branch
from
cd855b3 to
62a9af2
Compare
|
@kimishpatel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mcr229
approved these changes
Jun 2, 2025
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For macbooks it also takes the path of just querying perfcores which should actually work for ios as well.
Test Plan:
Use internal util and validate the behavior is as expected
Validated on iphone 14 pro
Reviewers:
Subscribers:
Tasks:
Tags: