Arm backend: Make pre-push non-interactive on one argument #11280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling pre-push as a git hook actually supplies it with 2 arguments, remote-name and remote-url. So the logic of automatically going non-interactive when there are any arguments is flawed. This commit makes sure pre-push only goes non-interactive when there is only one argument. Signed-off-by: per.held@arm.com Change-Id: I21cc05b24521bb075c2f74fe4ed7f773b797b085
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11280
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d122faf with merge base d4906e2 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
perheld
added
partner: arm
zingo
added
release notes: none
|
Unrelated fail |
zingo
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling pre-push as a git hook actually supplies it with 2 arguments, remote-name and remote-url. So the logic of automatically going non-interactive when there are any arguments is flawed.
This commit makes sure pre-push only goes non-interactive when there is only one argument.
Signed-off-by: per.held@arm.com
Change-Id: I21cc05b24521bb075c2f74fe4ed7f773b797b085
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218