Skip to content

fix unittest-buck2 -- buck test doesn't imply buck build #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

fix unittest-buck2 -- buck test doesn't imply buck build #11388

merged 2 commits into from
Jun 9, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 5, 2025

When I wrote this, I mistakenly thought that buck test would build all non-test targets it was passed, but it doesn't. Fix that, and fix a bunch of builds that we weren't guarding so that CI stays green.

@swolchok
Update
82ce372 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jun 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from manuelcandales as a code owner June 5, 2025 01:47
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11388

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 103 Pending

As of commit 8751628 with merge base a7a9130 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 5, 2025
@swolchok
fix unittest-buck2 -- buck test doesn't imply buck build
0351a1e 
When I wrote this, I mistakenly thought that `buck test` would build all non-test targets it was passed, but it doesn't. Fix that, and fix a bunch of builds that we weren't guarding so that CI stays green.


ghstack-source-id: 65df36d
ghstack-comment-id: 2942445080
Pull-Request-resolved: #11388
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jun 5, 2025
lucylq
lucylq approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@swolchok
rebase
8751628 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 9, 2025
@swolchok
fix unittest-buck2 -- buck test doesn't imply buck build
a492f1f 
When I wrote this, I mistakenly thought that `buck test` would build all non-test targets it was passed, but it doesn't. Fix that, and fix a bunch of builds that we weren't guarding so that CI stays green.

ghstack-source-id: c8401c4
ghstack-comment-id: 2942445080
Pull-Request-resolved: #11388
@swolchok
Copy link
Contributor Author

swolchok commented Jun 9, 2025

noting that tests were green before rebase, but we need to wait for unittest-buck2 to be green before landing

@swolchok
Copy link
Contributor Author

swolchok commented Jun 9, 2025

unittest-buck is green, merging

@swolchok swolchok merged commit ec6798d into main Jun 9, 2025
188 of 190 checks passed
@swolchok swolchok deleted the gh/swolchok/450/head branch June 9, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @lucylq @facebook-github-bot